Fixed Flag won't return if falling near death pit borders

[Ezer'Arch]

This is the simpler case to reproduce:
- open a CTF map and pick up the flag;
- toss the flag against a wall that borders a death pith, so the flag will fall near the death pit border;
- flag will not return.

This is the harder one:
- open a CTF map and pick up the flag;
- toss the flag from a higher place and let the flag fall exactly in a linedef where two death pit sectors meat each other;
- flag will not return.

Pics:



Workaround I adopted in my map: create a very thin intangible, invisible FOF with Return Flag sector type that spams over whole death pit. This never fails. ^_^

 

[Callum]

The flag's collision detection isn't working quite right, though in what way I'm not sure yet.

EDIT: The game checks for death pit object removal in P_XYMovement, maybe it should be in P_ZMovement instead, so it detects when the object hits the death pit instead of detecting movement over the death pit? The checks being in P_XYMovement stops anything without any moment from being removed.

 

[Callum]

Okay, fixed this bug. ;)

 

[Ultimate]

...Wow. Fixed another one just like that. I'm impressed for the second time today. Nice work.

 

[Ezer'Arch]

... just because you Callum deserve it :D

 

[Callum]

Is all that really necessary? =)

 

[Virt]

... just because you Callum deserve it :D

That should have been used on the "SSNTails is a Father!" thread. :P

 

[Bbop800]

Thank god, I was getting really sick of this bug.