Fixed Each time doesn't need of a sector special

[NeroTheArmadillo]

Spoiler

If you put a trigger linedef exec #302 with the linedef type #414 and #415, the sector does not do anything, since it is supossed to do only one time.

Edit: Also, I haven't tested with only one effect. the linedef 301 (each time, I think) works perfectly.

Edit2: Ignore the above.

The problem was the each time which active without any sector special.

 

[NeroTheArmadillo]

sorry for double post...


please respond...

 

[Ricardo]

Could not reproduce. Check your map again and see if you're putting the right tags in the right places, for example.

 

[NeroTheArmadillo]

Already tried, it works perfectly with each time, but with once it doesn't.

 

[Ricardo]

Hm. Can you upload the map?

 

[Callum]

I couldn't reproduce it either, with this quick test map.

Are you using these executors in rather unusual circumstances?

 

[Prime 2.0]

Please post your test wad so we can try to get an idea of what is actually happening.

 

[NeroTheArmadillo]

http://www.sendspace.com/file/xbuyn8

Red floor = Once effect

Blue floor = each time effect

EDIT: Nevermind, but it could effect like each time (Without Special sectors)

 

[Callum]

The sectors those two linedef executors are tagged to don't have the linedef exector trigger special applied to them. There is no bug here.

Edit: Actually, there is a bug, in this level, the Once trigger didn't activate (which is correct, because of no trigger sector special), but the Each Time trigger did. Maybe there is a broken conditional?

 

[NeroTheArmadillo]

Ok, Callum said the each time is bugged due to activating without sector special

 

[Callum]

Okay, I'll have a look at what I can do.

 

[Ricardo]

Actually, there is a bug, in this level, the Once trigger didn't activate (which is correct, because of no trigger sector special), but the Each Time trigger did. Maybe there is a broken conditional?

Yes, that is pretty much a bug in the game. I've come across with it before but never got to report it...

 

[Liliam]

SSNTails told me once that Each Time was rewritten to work differently to the other triggers, actively monitoring when players step inside the sector, so that might be why it's being set off without a trigger special. It's the same thing that causes "Floor Touch" triggers to activate, rather bizarrely, without touching the floor.

Frankly, this rubs me the wrong way because prior to the rewrite, in 1.09, Each Time triggers worked as expected at all times. But I mean, what am I supposed to say when somebody tells me a feature is broken on purpose?

 

[Ricardo]

Callum, it should probably be only required to add some conditions to T_EachTimeThinker and P_HavePlayersEnteredArea (src/p_floor.c). Conditions that depend on the sector effects that could allow, for example, to test if players are touching a sector's floor, instead of just entering it.

Of course, that's easier said than done. It may also be required to add new "vars" to the levelspecthink_t struct (passed as a parameter) to reflect the extra conditions :\

 

[Callum]

Okay, this bug has now been fixed.

 

[Ricardo]

Just curious, did you only fix the bug where Each Time worked without sector specials, or did you go a step further and fixed the matter of "Floor Touch" triggers as well? :3

 

[Callum]

Just curious, did you only fix the bug where Each Time worked without sector specials, or did you go a step further and fixed the matter of "Floor Touch" triggers as well? :3

No, that's a separate bug. I'll look into that soon.

EDIT: Okay, now it's fixed, Ricardo.