Fixed [2.1.18] SRB2 will try to use : after 9999 screenshots.

[SteelT]

After 9999 screenshots, if you attempt to create a new screenshot, an error showing "couldn't create screen shot srb2:000.png" will appear on console, easist way to do this is to create dummy files in a folder that goes from srb20000.png to srb29999.png

 

[Monster Iestyn]

https://github.com/STJr/SRB2/blob/next/src/m_misc.c#L588

Curiously enough it seems the game DOES try to detect going past # 9999, but it looks like it checks the wrong variable. So that's probably the goofup here.

If it worked it'd give the error message here:

https://github.com/STJr/SRB2/blob/next/src/m_misc.c#L1467

EDIT: Btw, the reason the game can't make a "srb2:000.png" screenshot file is probably because : is not allowed in filenames, so I've just reminded myself. =V

 

[Monster Iestyn]

http://git.magicalgirl.moe/STJr/SRB2/merge_requests/170

Made a merge request for my fix.

 

[AlamGBC]

http://git.magicalgirl.moe/STJr/SRB2/merge_requests/170

Made a merge request for my fix.

Mirrored Merge https://github.com/STJr/SRB2/pull/172

Linux x86 build

Windows x86 SDL2 build

 

[Monster Iestyn]

My fix has been merged to master, so this bug should be fixed for the next release/patch of SRB2.