Fixed [2.1.18] Linedef Special Call Lua Script can Crash

[Kitoko]

If you use the Call Lua Script linedef special with the front side upper texture having nothing at all (-) the game will just crash.

 

[Monster Iestyn]

I could not reproduce the crash making a test map of my own to reproduce the above. Any chance you could provide whatever map actually crashed?

More to the point, do you have a log of the crash itself, just in case it was something else?

 

[Kitoko]

Okay, let me get as much detail as possible.

Spoiler: Errorlog

SRB2 v2.1.17 -ERROR LOG-


srb2win caused an Access Violation in module msvcrt.dll at 0023:73ee8ff2.
Exception handler called in main thread.
Error occurred at 3/31/2017 18:45:38.
C:\Users\Kitoko\Desktop\SRB2_21\srb2win.exe, run by Kitoko.
4 processor(s), type 586 6.24067.
Program Memory from 0x00010000 to 0x7FFEFFFF
2048 MBytes physical memory.
Read from location 00000000 caused an access violation.

Registers:
EAX=50494c46 CS=0023 EIP=73ee8ff2 EFLGS=00010246
EBX=03f326a8 SS=002b ESP=01a8f75c EBP=01a8f788
ECX=00000000 DS=002b ESI=00000000 FS=0053
EDX=0245a7d8 ES=002b EDI=0993af38 GS=002b
Command Line parameters: -file C:\Users\Kitoko\Desktop\SRB2_21\SUBSPA~2.WAD C:\Users\Kitoko\AppData\Local\Temp\11smeb4q\du3tz1fw.wad -warp MAPI0 +devmode 1 +skin tails Bytes at CS : EIP:
3a ?? 01 ?? 75 ?? 2e ?? 0a ?? c0 ?? 74 ?? 26 ?? 3a ?? 61 ?? 01 ?? 75 ?? 25 ?? 0a ?? e4 ?? 74 ?? 
Stack dump:
01A8F75C: 00556157 0245A7D8 00000000 03ED05F8 03ED05F8 000000BD 00000000 09A4A8A8
01A8F77C: 098E4E58 0993AF38 09A54450 01A8F8D8 004BC186 0993AF38 09A54450 098E4E58
01A8F79C: 0000002B 73EA77C5 02450000 00000000 73EA77E4 72840EC2 09A54348 09A54348
01A8F7BC: 0CE61F68 00DC7BEA FFFFFFFE 73EA77E4 0042589C 01A8F7B0 00000004 01A8FFCC
01A8F7DC: 73EBD250 FFFFFFFE 03ECF840 01A8F818 00558A6C 03ECF840 FFFFFFFE 00000000
01A8F7FC: 00000000 00000000 00000000 00000000 00000000 09A54348 09A54348 01A8F858
01A8F81C: 0046D255 09A543FC 00000000 00200A21 00200A21 00000000 00000000 09A54450
01A8F83C: 0993AF38 00000000 09A54450 00000001 00000000 09A54348 00000001 01A8FB78
01A8F85C: 004A3161 09A54348 00000380 00000000 00000000 00000000 00000000 00000000
01A8F87C: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8F89C: 04468A8C 60643A99 0446DAB4 04456E6C 00000008 00000000 04456DEC 04468A8C
01A8F8BC: 04468A8C 01A8F8F8 60645B14 00002790 098E4E58 0993AF38 00000000 01A8F918
01A8F8DC: 004BDFF9 098E4E58 00000000 00000000 00000000 00000003 00000000 00000086
01A8F8FC: 012D5C98 00000004 098CBE28 01A8F930 00000000 09855498 00000000 01A8FB78
01A8F91C: 0047BBB2 09971F94 09A54450 098E4E58 00000002 FFFF06E2 09A54450 00000004
01A8F93C: FFFFFFFF 0017BA19 00000000 00000000 00000000 01A8FA60 01A8FAE0 FFFFFFFF
01A8F95C: 098E4E58 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8F97C: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8F99C: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8F9BC: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8F9DC: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8F9FC: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8FA1C: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8FA3C: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8FA5C: 00000000 00000001 00000000 00000000 00000000 00000000 00000000 00000000
01A8FA7C: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8FA9C: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8FABC: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8FADC: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8FAFC: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8FB1C: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8FB3C: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8FB5C: 00000000 00000000 4C47EF95 00000000 033915BD 00000001 00000001 01A8FCD8
01A8FB7C: 004CA052 09855498 00000000 01A8FCD8 004C9FF0 09841D50 00000000 01A8FC48
01A8FB9C: 00407CC1 01719510 09841D50 00000001 00000000 00000000 00000000 00000000
01A8FBBC: 00000000 00000000 00000000 00000000 00000000 09841D44 00000000 00000000
01A8FBDC: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8FBFC: 000001B3 00000014 00000125 01A8FC48 0040D5F2 00000000 006BCAF8 00000014
01A8FC1C: 00000001 00000000 00000000 00000000 00000000 006BBA00 00000000 01A8FCA8
01A8FC3C: 00000000 09841D44 09840000 01A8FCB8 004083D5 00000000 00000000 00000000
01A8FC5C: 00000003 000001B3 09841D44 01A8FC98 0040D1BC 006BCAF8 09841D44 00000014
01A8FC7C: 00000000 0172D3F0 00000000 00000000 00000020 00000125 00000001 01A8FCB8
01A8FC9C: 0040A972 00000000 006E06E0 00000028 00000020 00000126 00000000 01A8FDC8
01A8FCBC: 0040AC76 00000000 00000000 01A8FCE8 00000020 00000001 00000000 01A8FDB8
01A8FCDC: 00432D6F 00000001 01719510 00000008 000000A0 00000000 00000000 00000000
01A8FCFC: 00000000 00000020 00000000 00000000 00000000 00000020 00000000 00000000
01A8FD1C: 00000000 00000001 00000001 00000176 00000000 00000000 00000000 00000000
01A8FD3C: 00000000 00000000 00000000 00000000 00000001 00000176 00000000 01A8FDC8
01A8FD5C: 004083D5 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8FD7C: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8FD9C: 00000000 00000000 00000000 00000000 00000125 00000000 00000000 01A8FE08
01A8FDBC: 0040C0A4 00000001 00000000 01A8FE08 0040C03A 00000000 4C47EC70 00000000
01A8FDDC: 00000000 00000175 00000177 01A8FE18 0050CD49 4C47EC70 00000000 003436B5
01A8FDFC: 00000176 00000176 00000177 01A8FE38 00402A1D 00000001 00000175 01A8FE38
01A8FE1C: 00402AA1 01A8FE34 00000000 0043C1A0 016C8000 01A8FE68 0015F000 01A8FE78
01A8FE3C: 004013D5 00681063 0015F000 00000040 01A8FE68 001F0018 00030003 00400178
01A8FE5C: 0015F000 016C8000 00400000 00000040 001F00D8 001F01A0 0000000A 001F00D8
01A8FE7C: 005684CF 0000000A 001F01A0 01BD1ABC 00000002 001F01A0 0000000A 001F0018
01A8FE9C: 01BD32D6 01826A30 01826A30 01A8FF28 005681E7 00400000 00000000 01BD32D6
01A8FEBC: 00000001 73EA8094 73EA7DD4 006BA8EC 00568114 00000044 01BE46F0 01BD9488
01A8FEDC: 01BDD3A0 00000000 00000000 00000000 00000000 00000000 00000000 00000000
01A8FEFC: 00000401 00000001 00000000 00000000 00010001 00000000 0000000B 01A8FF20
01A8FF1C: 73E95809 01A8FF60 FFFFFFFF 01A8FF60 004011D9 0000000A 02452710 024514B8
01A8FF3C: 73EBD250 01A8FF60 004011B7 73EBCF15 73EBCF34 00000002 024514B8 00000000
01A8FF5C: 0037B000 01A8FF80 00401243 00000002 00000000 00000000 00000000 00000000
01A8FF7C: 00000000 01A8FF94 73D962C4 0037B000 73D962A0 5757C5B4 01A8FFDC 77070FD9
01A8FF9C: 0037B000 08516FD0 00000000 00000000 0037B000 C0000005 00000000 01A8F0EC
01A8FFBC: 7574D2E0 08516FD0 01A8FFA0 01A8F0EC 01A8FFE4 770867B0 7EE9171C 00000000
01A8FFDC: 01A8FFEC 77070FA4 FFFFFFFF 77092EE9 00000000 00000000 01826A30 0037B000
01A8FFFC: 00000000
Exception encountered during stack dump.

	Module list: names, addresses, sizes, time stamps and file times:
C:\Users\Kitoko\Desktop\SRB2_21\srb2win.exe, loaded at 0x00400000 - 2087079 bytes - 587d3e54 - file date is 1/16/2017 17:42:44
C:\Windows\System32\DriverStore\FileRepository\c0312242.inf_amd64_dba99477e2b8819f\aticfx32.dll, loaded at 0x041a0000 - 1307392 bytes - 58cafddf - file date is 3/21/2017 12:24:26
C:\Users\Kitoko\Desktop\SRB2_21\libvorbisfile-3.dll, loaded at 0x09d50000 - 62976 bytes - 52067b0b - file date is 8/10/2013 13:40:28
C:\Users\Kitoko\Desktop\SRB2_21\libmodplug-1.dll, loaded at 0x0a5e0000 - 401920 bytes - 52067b0b - file date is 8/10/2013 13:40:28
C:\Users\Kitoko\Desktop\SRB2_21\libFLAC-8.dll, loaded at 0x10000000 - 367104 bytes - 52067b0b - file date is 8/10/2013 13:40:28
C:\Windows\SYSTEM32\MSACM32.dll, loaded at 0x5f6a0000 - 90912 bytes - 57898f77 - file date is 7/16/2016 07:42:50
C:\Users\Kitoko\Desktop\SRB2_21\exchndl.dll, loaded at 0x603c0000 - 392704 bytes - 41486e57 - file date is 3/15/2014 13:06:10
C:\Windows\System32\DriverStore\FileRepository\c0312242.inf_amd64_dba99477e2b8819f\atiumdag.dll, loaded at 0x605f0000 - 7684832 bytes - 58cafb40 - file date is 3/21/2017 12:24:30
C:\Users\Kitoko\Desktop\SRB2_21\libintl-8.dll, loaded at 0x61cc0000 - 347910 bytes - 4d4a9e38 - file date is 3/15/2014 13:06:18
C:\Users\Kitoko\Desktop\SRB2_21\smpeg2.dll, loaded at 0x66240000 - 301568 bytes - 52067b0b - file date is 8/10/2013 13:40:28
C:\Users\Kitoko\Desktop\SRB2_21\SDL2_mixer.dll, loaded at 0x67880000 - 184320 bytes - 52067b0b - file date is 8/10/2013 13:40:28
C:\Windows\System32\DriverStore\FileRepository\c0312242.inf_amd64_dba99477e2b8819f\atiu9pag.dll, loaded at 0x69200000 - 134944 bytes - 58cafa87 - file date is 3/21/2017 12:24:30
C:\Windows\SYSTEM32\midimap.dll, loaded at 0x6af60000 - 18944 bytes - 5789910e - file date is 7/16/2016 07:42:50
C:\Windows\System32\XAudio2_7.dll, loaded at 0x6af70000 - 527192 bytes - 4c0641e5 - file date is 6/2/2010 05:55:30
C:\Windows\System32\DriverStore\FileRepository\c0312242.inf_amd64_dba99477e2b8819f\atiumdva.dll, loaded at 0x6b260000 - 11442896 bytes - 58cafbc6 - file date is 3/21/2017 12:24:30
C:\Users\Kitoko\Desktop\SRB2_21\SDL2.dll, loaded at 0x6c740000 - 1007104 bytes - 53250d74 - file date is 11/11/2014 15:44:12
C:\Windows\SYSTEM32\avrt.dll, loaded at 0x6cc50000 - 29448 bytes - 57898edc - file date is 7/16/2016 07:42:50
C:\Windows\SYSTEM32\D3D9.DLL, loaded at 0x6cc60000 - 1425000 bytes - 5819bf79 - file date is 11/2/2016 07:01:38
C:\Users\Kitoko\Desktop\SRB2_21\libvorbis-0.dll, loaded at 0x6d540000 - 196096 bytes - 52067b0b - file date is 8/10/2013 13:40:28
C:\Users\Kitoko\Desktop\SRB2_21\libgme.dll, loaded at 0x6e200000 - 488210 bytes - 516a380e - file date is 3/15/2014 13:05:58
C:\Windows\SYSTEM32\wdmaud.drv, loaded at 0x6e8e0000 - 207360 bytes - 57898eb8 - file date is 7/16/2016 07:42:50
C:\Windows\SYSTEM32\msacm32.drv, loaded at 0x6eae0000 - 24576 bytes - 5789910f - file date is 7/16/2016 07:42:50
C:\Windows\SYSTEM32\ksuser.dll, loaded at 0x6eaf0000 - 20672 bytes - 57898e69 - file date is 7/16/2016 07:42:50
C:\Windows\SYSTEM32\wintypes.dll, loaded at 0x6f000000 - 846560 bytes - 58ba5787 - file date is 3/4/2017 02:50:46
C:\Windows\SYSTEM32\AUDIOSES.DLL, loaded at 0x6f0d0000 - 484584 bytes - 58ba5fd8 - file date is 3/4/2017 03:57:42
C:\Windows\System32\DEVOBJ.dll, loaded at 0x6f150000 - 132232 bytes - 578990f1 - file date is 7/16/2016 07:42:56
C:\Windows\System32\MMDevApi.dll, loaded at 0x6f180000 - 352760 bytes - 58ba5a51 - file date is 3/4/2017 02:47:34
C:\Users\Kitoko\Desktop\SRB2_21\libogg-0.dll, loaded at 0x70680000 - 47104 bytes - 52067b0b - file date is 8/10/2013 13:40:28
C:\Windows\SYSTEM32\WINMMBASE.dll, loaded at 0x706c0000 - 131208 bytes - 578990a0 - file date is 7/16/2016 07:42:50
C:\Windows\SYSTEM32\WINMM.DLL, loaded at 0x706f0000 - 135376 bytes - 578990ae - file date is 7/16/2016 07:42:50
C:\Windows\SYSTEM32\IPHLPAPI.DLL, loaded at 0x723f0000 - 184416 bytes - 58ba585f - file date is 3/4/2017 03:02:54
C:\Windows\System32\PROPSYS.dll, loaded at 0x72560000 - 1375456 bytes - 57898fc3 - file date is 7/16/2016 07:42:56
C:\Windows\system32\uxtheme.dll, loaded at 0x72810000 - 457728 bytes - 578990a4 - file date is 7/16/2016 07:43:06
C:\Windows\system32\dwmapi.dll, loaded at 0x72890000 - 113504 bytes - 57dad275 - file date is 9/15/2016 13:13:52
C:\Windows\SYSTEM32\VERSION.dll, loaded at 0x728b0000 - 27360 bytes - 5789911a - file date is 7/16/2016 07:43:06
C:\Windows\System32\CRYPTBASE.dll, loaded at 0x73ac0000 - 31528 bytes - 57899141 - file date is 7/16/2016 07:42:50
C:\Windows\System32\SspiCli.dll, loaded at 0x73ad0000 - 117240 bytes - 584a7c96 - file date is 12/9/2016 05:51:10
C:\Windows\System32\sechost.dll, loaded at 0x73af0000 - 255168 bytes - 5789906f - file date is 7/16/2016 07:42:50
C:\Windows\System32\IMM32.DLL, loaded at 0x73b40000 - 144632 bytes - 578990f0 - file date is 7/16/2016 07:42:50
C:\Windows\System32\ucrtbase.dll, loaded at 0x73b70000 - 918304 bytes - 57898db2 - file date is 7/16/2016 07:42:56
C:\Windows\System32\msvcp_win.dll, loaded at 0x73d00000 - 498408 bytes - 5789909c - file date is 7/16/2016 07:42:56
C:\Windows\System32\KERNEL32.DLL, loaded at 0x73d80000 - 616048 bytes - 57898ef6 - file date is 7/16/2016 07:42:46
C:\Windows\System32\msvcrt.dll, loaded at 0x73e60000 - 773168 bytes - 57899155 - file date is 7/16/2016 07:42:50
C:\Windows\System32\cfgmgr32.dll, loaded at 0x73f20000 - 213848 bytes - 578990d6 - file date is 7/16/2016 07:42:56
C:\Windows\System32\combase.dll, loaded at 0x73f70000 - 2166752 bytes - 584a76ba - file date is 12/9/2016 05:59:26
C:\Windows\System32\powrprof.dll, loaded at 0x74190000 - 275832 bytes - 57898f27 - file date is 7/16/2016 07:42:56
C:\Windows\System32\GDI32.dll, loaded at 0x741e0000 - 170960 bytes - 57dad2ca - file date is 9/15/2016 13:23:20
C:\Windows\System32\clbcatq.dll, loaded at 0x74280000 - 528360 bytes - 57898ec3 - file date is 7/16/2016 07:42:48
C:\Windows\System32\WS2_32.DLL, loaded at 0x74370000 - 402352 bytes - 57dad27d - file date is 9/15/2016 13:37:06
C:\Windows\System32\USER32.dll, loaded at 0x743e0000 - 1435896 bytes - 584a7a33 - file date is 12/9/2016 05:52:22
C:\Windows\System32\windows.storage.dll, loaded at 0x74540000 - 5722320 bytes - 58ba59bd - file date is 3/4/2017 02:53:20
C:\Windows\System32\MSCTF.dll, loaded at 0x74ec0000 - 1260784 bytes - 58ba5810 - file date is 3/4/2017 02:42:30
C:\Windows\System32\OLEAUT32.dll, loaded at 0x75000000 - 601712 bytes - 5819c2b5 - file date is 11/2/2016 07:23:00
C:\Windows\System32\bcryptPrimitives.dll, loaded at 0x750a0000 - 367208 bytes - 57899108 - file date is 7/16/2016 07:42:28
C:\Windows\System32\win32u.dll, loaded at 0x75100000 - 79536 bytes - 57a023c2 - file date is 8/2/2016 00:47:22
C:\Windows\System32\ADVAPI32.DLL, loaded at 0x75170000 - 482392 bytes - 57898faf - file date is 7/16/2016 07:42:50
C:\Windows\System32\profapi.dll, loaded at 0x751f0000 - 54752 bytes - 57899121 - file date is 7/16/2016 07:42:50
C:\Windows\System32\gdi32full.dll, loaded at 0x75220000 - 1415240 bytes - 58ba5d85 - file date is 3/4/2017 02:42:40
C:\Windows\System32\RPCRT4.dll, loaded at 0x75380000 - 790760 bytes - 57a55b62 - file date is 8/6/2016 00:17:46
C:\Windows\System32\shcore.dll, loaded at 0x75460000 - 549088 bytes - 58ba5b2c - file date is 3/4/2017 02:53:00
C:\Windows\System32\ole32.dll, loaded at 0x754f0000 - 959112 bytes - 584a795d - file date is 12/9/2016 05:56:16
C:\Windows\System32\kernel.appcore.dll, loaded at 0x755e0000 - 43416 bytes - 5789916f - file date is 7/16/2016 07:42:56
C:\Windows\System32\KERNELBASE.dll, loaded at 0x755f0000 - 1706488 bytes - 58ba586d - file date is 3/4/2017 03:06:38
C:\Windows\System32\shlwapi.dll, loaded at 0x75a60000 - 284056 bytes - 57898fba - file date is 7/16/2016 07:43:04
C:\Windows\System32\SHELL32.DLL, loaded at 0x75ab0000 - 20969928 bytes - 58ba59ee - file date is 3/4/2017 02:47:26
C:\Windows\SYSTEM32\ntdll.dll, loaded at 0x77010000 - 1572768 bytes - 58256ca0 - file date is 11/11/2016 04:00:00

 

[K.S.]

MI, if no Lua scripts are loaded, linedef type 443 is a no-op, just like anything else that would poll Lua when no scripts are loaded.

LUAh_LinedefExecute doesn't do a null check on line->text, which is allocated dynamically, and in this specific case where the textures are all blank, is not actually allocated at all.

 

[Monster Iestyn]

Oh welp, I forgot to actually include a lua script in my test. I had figured it was to do with line->text, but without Lua initialised it's no wonder I didn't get the crash.

 

[Monster Iestyn]

http://git.magicalgirl.moe/STJr/SRB2/merge_requests/171 Alright here we go

EDIT: The fix has been merged to next now