Fixed [2.1.15] Colors 0, -1, and ? do random silly things. (Also random Blue Knuckles bug)

[Blaze The Cat]

addHook("ThinkFrame", do
    for player in players.iterate
        player.mo.color = 0
        player.color = 0
    end
end)

Forcefully setting these to zero does odd stuff.

Color -1 is even worse. That's totally "Blue" right there.

Then I got the idea of being able to force my color on the fly and made this.

COM_AddCommand("forcecolor", function(p, newcolor)
    p.mo.color = tonumber(newcolor)
    p.color = tonumber(newcolor)
end, 1)

So I decided to pay around and see what else is broken. And, interesting stuff happened.

Spoiler: Long GIF warning

 

[Lactozilla]

Color 0 is "none" (default mobj color?), and I dunno about -1.

 

[Monster Iestyn]

Pst, "player.color" doesn't actually exist normally, it's "player.skincolor" you want.


That said, I think I know what's going on here: -1 (or 255, since p.mo.color is UINT8) % MAXSKINCOLORS is 21, which happens to be Green. See, p.mo.color is limited to a number between 0 and MAXSKINCOLORS-1 in 2.1.14.

 

[chaoloveicemdboy]

I don't think this is a bug. I think this is intentional.

 

[toaster]

You'd be incorrect, then. Using out of range numbers should result in an error, not make a silently failing workaround attempt. Problems with scripts should be clearly communicated to the coder.

 

[K.S.]

On the other hand, being able to set color "none" is not a bug. Not updating the console variable is not a bug. (If you want to overwrite user choices, add stuff to the console buffer, duh.)