SRB2 Message Board

SRB2 Message Board (https://mb.srb2.org/index.php)
-   Bug Reports (2.1.X) (https://mb.srb2.org/forumdisplay.php?f=104)
-   -   Fixed [2.1.18] SRB2 will try to use : after 9999 screenshots. (https://mb.srb2.org/showthread.php?t=42508)

Steel Titanium 03-28-2017 03:50 AM

[2.1.18] SRB2 will try to use : after 9999 screenshots.
 
After 9999 screenshots, if you attempt to create a new screenshot, an error showing "couldn't create screen shot srb2:000.png" will appear on console, easist way to do this is to create dummy files in a folder that goes from srb20000.png to srb29999.png

Monster Iestyn 03-29-2017 02:16 AM

https://github.com/STJr/SRB2/blob/ne.../m_misc.c#L588

Curiously enough it seems the game DOES try to detect going past # 9999, but it looks like it checks the wrong variable. So that's probably the goofup here.

If it worked it'd give the error message here:

https://github.com/STJr/SRB2/blob/ne...m_misc.c#L1467

EDIT: Btw, the reason the game can't make a "srb2:000.png" screenshot file is probably because : is not allowed in filenames, so I've just reminded myself. =V

Monster Iestyn 03-29-2017 08:31 PM

http://git.magicalgirl.moe/STJr/SRB2/merge_requests/170

Made a merge request for my fix.

AlamGBC 03-29-2017 09:29 PM

Quote:

Originally Posted by Monster Iestyn (Post 790897)

Mirrored Merge https://github.com/STJr/SRB2/pull/172

Linux x86 build

Windows x86 SDL2 build

Monster Iestyn 03-30-2017 04:13 PM

My fix has been merged to master, so this bug should be fixed for the next release/patch of SRB2.


All times are GMT. The time now is 11:38 PM.

Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2017, vBulletin Solutions, Inc.