Fixed Elemental shield not protecting from Brak Eggman attacks correctly

MellowJacket

The unreliable judge

• Jan 15, 2020

• #1

See thread title. Black Eggman's flamethrower doesn't appear to be doing fire damage and will damage through an elemental shield that is supposed to give fire immunity.

Conversely, the elemental shield provides immunity to Black Eggman's electric shield and I don't think electricity counts as one of the damage types that elemental shields provide immunity to.

 

Katmint

‫‬‭‮‪‫‬‭‮

• Jan 15, 2020

• #2

These inconsistencies are a result of some hacky design around SRB2's water-fire interactions. See third post of this thread: https://mb.srb2.org/showthread.php?t=38689

 

Last edited: Jan 15, 2020

toaster

トースタちゃん

Kart Krew™️

• Jan 15, 2020

• #3

It can actually be fixed now, I think. Look for "DMG_SPIKE" in the infotables in info.c, then put DMG_FIRE and DMG_ELECTRIC into the same info fields for the respective objects!

 

jameds

jartha

Sonic Team Junior

Kart Krew™️

• Feb 3, 2020

• #4

Fixed here. https://git.magicalgirl.moe/STJr/SRB2/merge_requests/731

And then I realized only half of the issue was fixed (the flames).

 

Last edited: Feb 3, 2020

toaster

トースタちゃん

Kart Krew™️

• Feb 3, 2020

• #5

The other half was fixed in another branch, otherwise I would have done the thing there! (well, at least i think it was; the mass is set correctly for that object and it has MF_PAIN...)

 

sphere

Developer

Sonic Team Junior

• Nov 29, 2021

• #6

Fixed in https://git.do.srb2.org/STJr/SRB2/-/merge_requests/1660