SRB2 Message Board  

Go Back   SRB2 Message Board > Archived > SRB2 Forum Archives > Bug Reports (2.1.X)

 
 
Thread Tools Search this Thread
Old 09-25-2016   #1
Zwip-Zwap Zapony
Please just call me Zappy.
 
Zwip-Zwap Zapony's Avatar
Default [2.1.17] Releasing Shift while other Shift is held un-Shifts

When working on customizable menu controls (still working on it), I noticed a potential error, tested it to see if it would happen in-game, and it does happen.


Specifically, if you hold one of the two Shift buttons, stuff you type becomes upper-case, holding the other also makes it upper-case... but releasing Shift makes it become lower-case, even if the other Shift is still held.

This happens in the console on the title screen, the console in-game, and the chat in-game, and probably everywhere else that considers Shifts too.


Relevant code, in src/m_menu.c at lines 2083-2087:
Code:
    if (ev->type == ev_keyup && (ev->data1 == KEY_LSHIFT || ev->data1 == KEY_RSHIFT))
    {
        shiftdown = false;
        return false;
    }
This code sets "shiftdown" to false if you release the left or right Shift keys, but it doesn't check if you're holding the other Shift key first. This is an extremely minor issue, though.

Last edited by toaster; 12-06-2016 at 10:43 PM.
Zwip-Zwap Zapony is offline  
Old 09-30-2016   #2
toaster
トースタちゃん
Developer
 
toaster's Avatar
Default

Create a merge request solely for bugfixing this and I'll personally +1 it for going into next.
__________________
Quote:
<MonsterIestyn> surely it's good ass though
Quote:
<MonsterIestyn> watch porm to keep warm
toaster is offline  
Old 10-01-2016   #3
Zwip-Zwap Zapony
Please just call me Zappy.
 
Zwip-Zwap Zapony's Avatar
Default

Don't worry, if it doesn't get fixed by someone else before I wrap up my customizable menu control stuff eventually, I plan to fix it myself within the menu control stuff.
(And if someone else fixes it first, I'll be sure to include that fix in my customizable menu control stuff.)
For now, though, I'm working too much on manipulating the menu system to easily fix just this "un-Shift" issue, especially without it being redundant to make that bugfix when it's gonna be in my menu control stuff eventually anyway.

Last edited by Zwip-Zwap Zapony; 10-01-2016 at 08:33 AM.
Zwip-Zwap Zapony is offline  
Old 12-06-2016   #4
toaster
トースタちゃん
Developer
 
toaster's Avatar
Default

Fixed in next.
__________________
Quote:
<MonsterIestyn> surely it's good ass though
Quote:
<MonsterIestyn> watch porm to keep warm
toaster is offline  
 
Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 03:01 PM.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2017, vBulletin Solutions, Inc.