SRB2 Message Board  

Go Back   SRB2 Message Board > Sonic Robo Blast 2 > SRB2 Discussion > Bug Reports

Closed Thread
 
Thread Tools Search this Thread
Old 07-17-2017   #1
Simsmagic
i 2 i
 
Simsmagic's Avatar
Default FOFs cause ground below's Each Time trigger to fire

Picture a floor that uses Linedef Type 301 (Each Time) to trigger a linedef, it doesn't matter what's being triggered. If an FOF is placed above this floor, said FOF will also trigger the effect even if the control sector isn't tagged or has the proper sector special.

Link to a test level that demonstrates the bug
Link to a .gif showcasing the bug

The left FOF showcases the bug, using an Each Time trigger. The right FOF uses a Continuous trigger, which does not have this bug. Both sectors are using the Floor Touch sector special and are triggering the Award Score effect (though I've tested, and it seems to happen with other effects like Teleport), and neither control sector for the FOF interacts with the executors in any way. There's no way the executor is being triggered unintentionally due to something I did, as far as I can tell.

Last edited by Monster Iestyn; 08-16-2017 at 07:18 PM.
Simsmagic is offline  
Old 07-17-2017   #2
Monster Iestyn
Friendly Neighbour-Hood
Moderator
 
Monster Iestyn's Avatar
Default

This happens because the special thinker for Each Time uses P_IsObjectOnGroundIn to determine on-groundness ...which does not distinguish between normal ground and an FOF "ground". So yeah, definitely the game's fault in this case.

Fun other extra bug I found with P_IsObjectOnGroundIn itself: turns out it even counts touching the top of intangible FOFs as being on the ground (blame stupid coding). This means Each Time triggers for the normal ground are activated for those too!
__________________
My page stuffed full of MIDI goodness!
The Hitchhiker's Guide to the Robo-Hoodiverse
Timeline of Sonic Robo Blast History!

That's an uppercase i, not a lowercase L, for the record.
Monster Iestyn is offline  
Old 07-17-2017   #3
Monster Iestyn
Friendly Neighbour-Hood
Moderator
 
Monster Iestyn's Avatar
Default

http://git.magicalgirl.moe/STJr/SRB2/merge_requests/204

Made a fix for this bug here.
__________________
My page stuffed full of MIDI goodness!
The Hitchhiker's Guide to the Robo-Hoodiverse
Timeline of Sonic Robo Blast History!

That's an uppercase i, not a lowercase L, for the record.
Monster Iestyn is offline  
Old 08-16-2017   #4
Monster Iestyn
Friendly Neighbour-Hood
Moderator
 
Monster Iestyn's Avatar
Default

Oh wow, forgot I merged the fix above to "next" 4 weeks ago. Yeah, this bug will be fixed now for the next release or patch.
__________________
My page stuffed full of MIDI goodness!
The Hitchhiker's Guide to the Robo-Hoodiverse
Timeline of Sonic Robo Blast History!

That's an uppercase i, not a lowercase L, for the record.
Monster Iestyn is offline  
Closed Thread
Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 02:04 AM.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2017, vBulletin Solutions, Inc.